Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 679ef4ea authored by Johannes Berg's avatar Johannes Berg
Browse files

mac80211: use oper_channel in utils and config 



Using hw.conf.channel is wrong as it could be the
temporary channel if any function like the beacon
get function is called while scanning or during
other temporary out-of-channel activities.

Use oper_channel instead.

Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 568d6e28

net/mac80211/cfg.c

+3 −3
Original line number Diff line number Diff line
@@ -330,7 +330,7 @@ static void rate_idx_to_bitrate(struct rate_info *rate, struct sta_info *sta, in 
	if (!(rate->flags & RATE_INFO_FLAGS_MCS)) {

		struct ieee80211_supported_band *sband;

		sband = sta->local->hw.wiphy->bands[

				sta->local->hw.conf.channel->band];

				sta->local->oper_channel->band];

		rate->legacy = sband->bitrates[idx].bitrate;

	} else

		rate->mcs = idx;
@@ -1662,7 +1662,7 @@ static int ieee80211_change_bss(struct wiphy *wiphy, 
	}



	if (!sdata->vif.bss_conf.use_short_slot &&

	    sdata->local->hw.conf.channel->band == IEEE80211_BAND_5GHZ) {

	    sdata->local->oper_channel->band == IEEE80211_BAND_5GHZ) {

		sdata->vif.bss_conf.use_short_slot = true;

		changed |= BSS_CHANGED_ERP_SLOT;

	}
@@ -1928,7 +1928,7 @@ static int ieee80211_set_tx_power(struct wiphy *wiphy, 
				  enum nl80211_tx_power_setting type, int mbm)

{

	struct ieee80211_local *local = wiphy_priv(wiphy);

	struct ieee80211_channel *chan = local->hw.conf.channel;

	struct ieee80211_channel *chan = local->oper_channel;

	u32 changes = 0;



	switch (type) {

net/mac80211/iface.c

+1 −1
Original line number Diff line number Diff line
@@ -1274,7 +1274,7 @@ int ieee80211_if_change_type(struct ieee80211_sub_if_data *sdata, 
	/* reset some values that shouldn't be kept across type changes */

	sdata->vif.bss_conf.basic_rates =

		ieee80211_mandatory_rates(sdata->local,

			sdata->local->hw.conf.channel->band);

			sdata->local->oper_channel->band);

	sdata->drop_unencrypted = 0;

	if (type == NL80211_IFTYPE_STATION)

		sdata->u.mgd.use_4addr = false;

net/mac80211/util.c

+2 −2
Original line number Diff line number Diff line
@@ -832,7 +832,7 @@ void ieee80211_set_wmm_default(struct ieee80211_sub_if_data *sdata, 


	memset(&qparam, 0, sizeof(qparam));



	use_11b = (local->hw.conf.channel->band == IEEE80211_BAND_2GHZ) &&

	use_11b = (local->oper_channel->band == IEEE80211_BAND_2GHZ) &&

		 !(sdata->flags & IEEE80211_SDATA_OPERATING_GMODE);



	/*
@@ -919,7 +919,7 @@ void ieee80211_sta_def_wmm_params(struct ieee80211_sub_if_data *sdata, 
		if ((supp_rates[i] & 0x7f) * 5 > 110)

			have_higher_than_11mbit = 1;



	if (local->hw.conf.channel->band == IEEE80211_BAND_2GHZ &&

	if (local->oper_channel->band == IEEE80211_BAND_2GHZ &&

	    have_higher_than_11mbit)

		sdata->flags |= IEEE80211_SDATA_OPERATING_GMODE;

	else