Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6798e901 authored by Andrey Smirnov's avatar Andrey Smirnov Committed by Greg Kroah-Hartman
Browse files

tty: serial: fsl_lpuart: Ignore TX/RX interrupts if DMA is enabled 



In a mixed DMA/IRQ use-case (e.g.: DMA for TX, IRQ for RX), interrupt
handler might try to handle Rx/Tx condition it shouldn't. Change the
code to only handle TX/RX event if corresponding path isn't being
handled by DMA.

Signed-off-by: default avatarAndrey Smirnov <andrew.smirnov@gmail.com>
Cc: Stefan Agner <stefan@agner.ch>
Cc: Chris Healy <cphealy@gmail.com>
Cc: Cory Tusar <cory.tusar@zii.aero>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.com>
Cc: linux-imx@nxp.com
Cc: linux-serial@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Link: https://lore.kernel.org/r/20190805185701.22863-7-andrew.smirnov@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f7ec1721

drivers/tty/serial/fsl_lpuart.c

+2 −2
Original line number Diff line number Diff line
@@ -967,10 +967,10 @@ static irqreturn_t lpuart_int(int irq, void *dev_id) 


	sts = readb(sport->port.membase + UARTSR1);



	if (sts & UARTSR1_RDRF)

	if (sts & UARTSR1_RDRF && !sport->lpuart_dma_rx_use)

		lpuart_rxint(sport);



	if (sts & UARTSR1_TDRE)

	if (sts & UARTSR1_TDRE && !sport->lpuart_dma_tx_use)

		lpuart_txint(sport);



	return IRQ_HANDLED;