Commit 6765fda0 authored Feb 28, 2019 by Oded Gabbay Committed by Greg Kroah-Hartman Feb 28, 2019

habanalabs: fix validation of WREG32 to DMA completion



This patch fix a bug in the validation of WREG32 in DMA queues. The
validation was too strict. It allowed the user to set the completion
address only for DMA channel 1.

The fix allows the user to set the completion address for all 5 DMA
channels.

Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 1e7c1ec1

drivers/misc/habanalabs/goya/goya.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3769,7 +3769,7 @@ static int goya_validate_wreg32(struct hl_device *hdev,
		dev_dbg(hdev->dev, "reg_offset == 0x%x\n", reg_offset);
		dev_dbg(hdev->dev, "value == 0x%x\n", wreg_pkt->value);

		if (reg_offset != (mmDMA_CH_1_WR_COMP_ADDR_LO & 0xFFFF)) {
		if (reg_offset != (mmDMA_CH_0_WR_COMP_ADDR_LO & 0x1FFF)) {
		dev_err(hdev->dev, "WREG32 packet with illegal address 0x%x\n",
		reg_offset);
		return -EPERM;