Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 673831da authored by Jia-Ju Bai's avatar Jia-Ju Bai Committed by Dmitry Torokhov
Browse files

Input: keyspan_remote - replace GFP_ATOMIC with GFP_KERNEL in keyspan_probe() 



keyspan_probe() is never called in atomic context. It calls
usb_alloc_coherent() with GFP_ATOMIC, which is not necessary. GFP_ATOMIC
can be replaced with GFP_KERNEL.

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: default avatarJia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent e58650b5

drivers/input/misc/keyspan_remote.c

+1 −1
Original line number Diff line number Diff line
@@ -466,7 +466,7 @@ static int keyspan_probe(struct usb_interface *interface, const struct usb_devic 
	remote->in_endpoint = endpoint;

	remote->toggle = -1;	/* Set to -1 so we will always not match the toggle from the first remote message. */



	remote->in_buffer = usb_alloc_coherent(udev, RECV_SIZE, GFP_ATOMIC, &remote->in_dma);

	remote->in_buffer = usb_alloc_coherent(udev, RECV_SIZE, GFP_KERNEL, &remote->in_dma);

	if (!remote->in_buffer) {

		error = -ENOMEM;

		goto fail1;