Commit 6710f970 authored May 02, 2018 by Pavel Tatashin Committed by Jeff Kirsher May 17, 2018

ixgbe: release lock for the duration of ixgbe_suspend_close()



Currently, during device_shutdown() ixgbe holds rtnl_lock for the duration
of lengthy ixgbe_close_suspend(). On machines with multiple ixgbe cards
this lock prevents scaling if device_shutdown() function is multi-threaded.

It is not necessary to hold this lock during ixgbe_close_suspend()
as it is not held when ixgbe_close() is called also during shutdown but for
kexec case.

Signed-off-by: Pavel Tatashin <pasha.tatashin@oracle.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

parent b212d815

drivers/net/ethernet/intel/ixgbe/ixgbe_main.c

+8 −1

Original line number	Diff line number	Diff line
		@@ -6698,8 +6698,15 @@ static int __ixgbe_shutdown(struct pci_dev pdev, bool enable_wake)
		rtnl_lock();
		netif_device_detach(netdev);

		if (netif_running(netdev))
		if (netif_running(netdev)) {
		/* Suspend takes a long time, device_shutdown may be
		* parallelized this function, so drop lock for the
		* duration of this call.
		*/
		rtnl_unlock();
		ixgbe_close_suspend(adapter);
		rtnl_lock();
		}

		ixgbe_clear_interrupt_scheme(adapter);
		rtnl_unlock();