Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 670d8be2 authored by Damien Le Moal's avatar Damien Le Moal Committed by Martin K. Petersen
Browse files

scsi: sd: Improve unaligned completion resid message 

For commands completing with a resid not aligned on the device logical
sector size, also print the command CDB in addition to the current message
to help debug hardware generating such incorrect command completion
information.

Link: https://lore.kernel.org/r/20190828053511.14818-1-damien.lemoal@wdc.com


Signed-off-by: default avatarDamien Le Moal <damien.lemoal@wdc.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 3ec24fb4

drivers/scsi/sd.c

+1 −0
Original line number Diff line number Diff line
@@ -1978,6 +1978,7 @@ static int sd_done(struct scsi_cmnd *SCpnt) 
			sd_printk(KERN_INFO, sdkp,

				"Unaligned partial completion (resid=%u, sector_sz=%u)\n",

				resid, sector_size);

			scsi_print_command(SCpnt);

			resid = min(scsi_bufflen(SCpnt),

				    round_up(resid, sector_size));

			scsi_set_resid(SCpnt, resid);