Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 66a3479e authored by Himanshu Jha's avatar Himanshu Jha Committed by Kalle Valo
Browse files

rsi: remove memset before memcpy 



calling memcpy immediately after memset with the same region of memory
makes memset redundant.

Signed-off-by: default avatarHimanshu Jha <himanshujha199640@gmail.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent 83ec4891

drivers/net/wireless/rsi/rsi_91x_sdio.c

+0 −1
Original line number Original line Diff line number Diff line
@@ -584,7 +584,6 @@ static int rsi_sdio_load_data_master_write(struct rsi_hw *adapter, 
	}

	}





	for (offset = 0, i = 0; i < num_blocks; i++, offset += block_size) {

	for (offset = 0, i = 0; i < num_blocks; i++, offset += block_size) {

		memset(temp_buf, 0, block_size);

		memcpy(temp_buf, ta_firmware + offset, block_size);

		memcpy(temp_buf, ta_firmware + offset, block_size);

		lsb_address = (u16)base_address;

		lsb_address = (u16)base_address;

		status = rsi_sdio_write_register_multiple

		status = rsi_sdio_write_register_multiple

drivers/net/wireless/rsi/rsi_91x_usb.c

+0 −1
Original line number Original line Diff line number Diff line
@@ -439,7 +439,6 @@ static int rsi_usb_load_data_master_write(struct rsi_hw *adapter, 
	rsi_dbg(INFO_ZONE, "num_blocks: %d\n", num_blocks);

	rsi_dbg(INFO_ZONE, "num_blocks: %d\n", num_blocks);





	for (cur_indx = 0, i = 0; i < num_blocks; i++, cur_indx += block_size) {

	for (cur_indx = 0, i = 0; i < num_blocks; i++, cur_indx += block_size) {

		memset(temp_buf, 0, block_size);

		memcpy(temp_buf, ta_firmware + cur_indx, block_size);

		memcpy(temp_buf, ta_firmware + cur_indx, block_size);

		status = rsi_usb_write_register_multiple(adapter, base_address,

		status = rsi_usb_write_register_multiple(adapter, base_address,

							 (u8 *)(temp_buf),

							 (u8 *)(temp_buf),