bpf: remove redundant assignment to err (6685699e) · Commits · e / devices / android_kernel_fairphone_FP5

The variable err is assigned with the value -EINVAL that is never read and it is re-assigned a new value later on. The assignment is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by:

Colin Ian King <colin.king@canonical.com> Acked-by:

Jesper Dangaard Brouer <brouer@redhat.com> Signed-off-by:

Daniel Borkmann <daniel@iogearbox.net>

kernel/bpf/devmap.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -88,8 +88,8 @@ static u64 dev_map_bitmap_size(const union bpf_attr *attr)
		static struct bpf_map dev_map_alloc(union bpf_attr attr)
		{
		struct bpf_dtab *dtab;
		int err = -EINVAL;
		u64 cost;
		int err;

		if (!capable(CAP_NET_ADMIN))
		return ERR_PTR(-EPERM);

kernel/bpf/xskmap.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -17,8 +17,8 @@ struct xsk_map {

		static struct bpf_map xsk_map_alloc(union bpf_attr attr)
		{
		int cpu, err = -EINVAL;
		struct xsk_map *m;
		int cpu, err;
		u64 cost;

		if (!capable(CAP_NET_ADMIN))