Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 665f37e7 authored by Wei Yongjun's avatar Wei Yongjun Committed by Eric Anholt
Browse files

drm/pl111: Fix return value check in pl111_amba_probe() 



In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().

Fixes: bed41005 ("drm/pl111: Initial drm/kms driver for pl111")
Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: default avatarEric Anholt <eric@anholt.net>
Link: http://patchwork.freedesktop.org/patch/msgid/20170521010152.6186-1-weiyj.lk@gmail.com
parent f90dee20

drivers/gpu/drm/pl111/pl111_drv.c

+2 −2
Original line number Diff line number Diff line
@@ -200,9 +200,9 @@ static int pl111_amba_probe(struct amba_device *amba_dev, 
	drm->dev_private = priv;



	priv->regs = devm_ioremap_resource(dev, &amba_dev->res);

	if (!priv->regs) {

	if (IS_ERR(priv->regs)) {

		dev_err(dev, "%s failed mmio\n", __func__);

		return -EINVAL;

		return PTR_ERR(priv->regs);

	}



	/* turn off interrupts before requesting the irq */