Commit 6650fa5f authored Dec 30, 2021 by Jiasheng Jiang Committed by Greg Kroah-Hartman Mar 08, 2022

soc: fsl: qe: Check of ioremap return value



[ Upstream commit a222fd8541394b36b13c89d1698d9530afd59a9c ]

As the possible failure of the ioremap(), the par_io could be NULL.
Therefore it should be better to check it and return error in order to
guarantee the success of the initiation.
But, I also notice that all the caller like mpc85xx_qe_par_io_init() in
`arch/powerpc/platforms/85xx/common.c` don't check the return value of
the par_io_init().
Actually, par_io_init() needs to check to handle the potential error.
I will submit another patch to fix that.
Anyway, par_io_init() itsely should be fixed.

Fixes: 7aa1aa6e ("QE: Move QE from arch/powerpc to drivers/soc")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Signed-off-by: Li Yang <leoyang.li@nxp.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent e89c53fc

drivers/soc/fsl/qe/qe_io.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -37,6 +37,8 @@ int par_io_init(struct device_node *np)
		if (ret)
		return ret;
		par_io = ioremap(res.start, resource_size(&res));
		if (!par_io)
		return -ENOMEM;

		num_ports = of_get_property(np, "num-ports", NULL);
		if (num_ports)