Commit 6602769b authored Aug 08, 2013 by Jingoo Han Committed by Greg Kroah-Hartman Aug 12, 2013

serial: mrst_max3110: fix casting warning

max->port.membase is (unsigned char __iomem *); thus,
casting (unsigned char __iomem *) is necessary to fix
the following warning. Also, serial_m3110_ops() is staticized.

drivers/tty/serial/mrst_max3110.c:716:17: warning: symbol 'serial_m3110_ops' was not declared. Should it be static?
drivers/tty/serial/mrst_max3110.c:847:27: warning: incorrect type in assignment (different address spaces)
drivers/tty/serial/mrst_max3110.c:847:27: expected unsigned char [noderef] <asn:2>*membase
drivers/tty/serial/mrst_max3110.c:847:27: got void *<noident>

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 75474b6f

drivers/tty/serial/mrst_max3110.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -713,7 +713,7 @@ static void serial_m3110_enable_ms(struct uart_port *port)
		{
		}

		struct uart_ops serial_m3110_ops = {
		static struct uart_ops serial_m3110_ops = {
		.tx_empty = serial_m3110_tx_empty,
		.set_mctrl = serial_m3110_set_mctrl,
		.get_mctrl = serial_m3110_get_mctrl,
		@@ -844,7 +844,7 @@ static int serial_m3110_probe(struct spi_device *spi)
		pmax = max;

		/* Give membase a psudo value to pass serial_core's check */
		max->port.membase = (void *)0xff110000;
		max->port.membase = (unsigned char __iomem *)0xff110000;
		uart_add_one_port(&serial_m3110_reg, &max->port);

		return 0;