Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 65f32d1e authored by Niklas Söderlund's avatar Niklas Söderlund Committed by Greg Kroah-Hartman
Browse files

thermal/drivers/rcar_gen3_thermal: Fix coefficient calculations 



[ Upstream commit 8946187ab57ffd02088e50256c73dd31f49db06d ]

The fixed value of 157 used in the calculations are only correct for
M3-W, on other Gen3 SoC it should be 167. The constant can be derived
correctly from the static TJ_3 constant and the SoC specific TJ_1 value.
Update the calculation be correct on all Gen3 SoCs.

Fixes: 4eb39f79 ("thermal: rcar_gen3_thermal: Update value of Tj_1")
Reported-by: default avatarYoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: default avatarNiklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: default avatarYoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Reviewed-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20210605085211.564909-1-niklas.soderlund+renesas@ragnatech.se


Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent a3ea516d

drivers/thermal/rcar_gen3_thermal.c

+1 −1
Original line number Diff line number Diff line
@@ -143,7 +143,7 @@ static void rcar_gen3_thermal_calc_coefs(struct rcar_gen3_thermal_tsc *tsc, 
	 * Division is not scaled in BSP and if scaled it might overflow

	 * the dividend (4095 * 4095 << 14 > INT_MAX) so keep it unscaled

	 */

	tsc->tj_t = (FIXPT_INT((ptat[1] - ptat[2]) * 157)

	tsc->tj_t = (FIXPT_INT((ptat[1] - ptat[2]) * (ths_tj_1 - TJ_3))

		     / (ptat[0] - ptat[2])) + FIXPT_INT(TJ_3);



	tsc->coef.a1 = FIXPT_DIV(FIXPT_INT(thcode[1] - thcode[2]),