Commit 65d36ec4 authored Jun 03, 2022 by Miaoqian Lin Committed by Greg Kroah-Hartman Aug 25, 2022

usb: ohci-nxp: Fix refcount leak in ohci_hcd_nxp_probe



[ Upstream commit 302970b4cad3ebfda2c05ce06c322ccdc447d17e ]

of_parse_phandle() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.

Fixes: 73108aa9 ("USB: ohci-nxp: Use isp1301 driver")
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220603141231.979-1-linmq006@gmail.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 8cbc3870

drivers/usb/host/ohci-nxp.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -164,6 +164,7 @@ static int ohci_hcd_nxp_probe(struct platform_device *pdev)
		}

		isp1301_i2c_client = isp1301_get_client(isp1301_node);
		of_node_put(isp1301_node);
		if (!isp1301_i2c_client)
		return -EPROBE_DEFER;