Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 64866e5d authored by Luca Coelho's avatar Luca Coelho
Browse files

iwlwifi: move iwl_nvm_check_version() into dvm 



This function is only half-used by mvm (i.e. only the nvm_version part
matters, since the calibration version is irrelevant), so it's
pointless to export it from iwlwifi.  If mvm uses this function, it
has the additional complexity of setting the calib version to a bogus
value on all cfg structs.

To avoid this, move the function to dvm and make a simple comparison
of the nvm_version in mvm instead.

Signed-off-by: default avatarLuca Coelho <luciano.coelho@intel.com>
parent 4aeaccd6

drivers/net/wireless/intel/iwlwifi/dvm/main.c

+17 −0
Original line number Diff line number Diff line
@@ -1224,6 +1224,23 @@ static int iwl_eeprom_init_hw_params(struct iwl_priv *priv) 
	return 0;

}



static int iwl_nvm_check_version(struct iwl_nvm_data *data,

				 struct iwl_trans *trans)

{

	if (data->nvm_version >= trans->cfg->nvm_ver ||

	    data->calib_version >= trans->cfg->nvm_calib_ver) {

		IWL_DEBUG_INFO(trans, "device EEPROM VER=0x%x, CALIB=0x%x\n",

			       data->nvm_version, data->calib_version);

		return 0;

	}



	IWL_ERR(trans,

		"Unsupported (too old) EEPROM VER=0x%x < 0x%x CALIB=0x%x < 0x%x\n",

		data->nvm_version, trans->cfg->nvm_ver,

		data->calib_version,  trans->cfg->nvm_calib_ver);

	return -EINVAL;

}



static struct iwl_op_mode *iwl_op_mode_dvm_start(struct iwl_trans *trans,

						 const struct iwl_cfg *cfg,

						 const struct iwl_fw *fw,

drivers/net/wireless/intel/iwlwifi/iwl-eeprom-parse.c

+0 −19
Original line number Diff line number Diff line
@@ -927,22 +927,3 @@ iwl_parse_eeprom_data(struct device *dev, const struct iwl_cfg *cfg, 
	return NULL;

}

IWL_EXPORT_SYMBOL(iwl_parse_eeprom_data);
 


/* helper functions */

int iwl_nvm_check_version(struct iwl_nvm_data *data,

			     struct iwl_trans *trans)

{

	if (data->nvm_version >= trans->cfg->nvm_ver ||

	    data->calib_version >= trans->cfg->nvm_calib_ver) {

		IWL_DEBUG_INFO(trans, "device EEPROM VER=0x%x, CALIB=0x%x\n",

			       data->nvm_version, data->calib_version);

		return 0;

	}



	IWL_ERR(trans,

		"Unsupported (too old) EEPROM VER=0x%x < 0x%x CALIB=0x%x < 0x%x\n",

		data->nvm_version, trans->cfg->nvm_ver,

		data->calib_version,  trans->cfg->nvm_calib_ver);

	return -EINVAL;

}

IWL_EXPORT_SYMBOL(iwl_nvm_check_version);

drivers/net/wireless/intel/iwlwifi/iwl-eeprom-parse.h

+2 −3
Original line number Diff line number Diff line
@@ -7,6 +7,7 @@ 
 *

 * Copyright(c) 2008 - 2014 Intel Corporation. All rights reserved.

 * Copyright(c) 2015 Intel Mobile Communications GmbH

 * Copyright (C) 2018 Intel Corporation

 *

 * This program is free software; you can redistribute it and/or modify

 * it under the terms of version 2 of the GNU General Public License as
@@ -28,6 +29,7 @@ 
 *

 * Copyright(c) 2005 - 2014 Intel Corporation. All rights reserved.

 * Copyright(c) 2015 Intel Mobile Communications GmbH

 * Copyright (C) 2018 Intel Corporation

 * All rights reserved.

 *

 * Redistribution and use in source and binary forms, with or without
@@ -117,9 +119,6 @@ struct iwl_nvm_data * 
iwl_parse_eeprom_data(struct device *dev, const struct iwl_cfg *cfg,

		      const u8 *eeprom, size_t eeprom_size);



int iwl_nvm_check_version(struct iwl_nvm_data *data,

			  struct iwl_trans *trans);



int iwl_init_sband_channels(struct iwl_nvm_data *data,

			    struct ieee80211_supported_band *sband,

			    int n_channels, enum nl80211_band band);

drivers/net/wireless/intel/iwlwifi/mvm/fw.c

+3 −1
Original line number Diff line number Diff line
@@ -547,7 +547,9 @@ int iwl_run_init_mvm_ucode(struct iwl_mvm *mvm, bool read_nvm) 
	if (mvm->nvm_file_name)

		iwl_mvm_load_nvm_to_nic(mvm);



	WARN_ON(iwl_nvm_check_version(mvm->nvm_data, mvm->trans));

	WARN_ONCE(mvm->nvm_data->nvm_version < mvm->trans->cfg->nvm_ver,

		  "Too old NVM version (0x%0x, required = 0x%0x)",

		  mvm->nvm_data->nvm_version, mvm->trans->cfg->nvm_ver);



	/*

	 * abort after reading the nvm in case RF Kill is on, we will complete