Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 647685e6 authored by Can Guo's avatar Can Guo Committed by Todd Kjos
Browse files

FROMLIST: scsi: ufs: Remove the check before call setup clock notify vops 

The functionality of vendor specific ops should be handled properly in
platform specific driver, but should not count on the UFS driver.

Bug: 143632303
Change-Id: Icad6554319f031b73c3ead28b74c38246ccc3fff
Link: https://lore.kernel.org/patchwork/patch/1149890/


Signed-off-by: default avatarCan Guo <cang@codeaurora.org>
Signed-off-by: default avatarAsutosh Das <asutoshd@codeaurora.org>
parent 8905bcf2

drivers/scsi/ufs/ufshcd.c

+6 −20
Original line number Diff line number Diff line
@@ -7380,16 +7380,9 @@ static int __ufshcd_setup_clocks(struct ufs_hba *hba, bool on, 
	if (list_empty(head))

		goto out;



	/*

	 * vendor specific setup_clocks ops may depend on clocks managed by

	 * this standard driver hence call the vendor specific setup_clocks

	 * before disabling the clocks managed here.

	 */

	if (!on) {

	ret = ufshcd_vops_setup_clocks(hba, on, PRE_CHANGE);

	if (ret)

		return ret;

	}



	list_for_each_entry(clki, head, list) {

		if (!IS_ERR_OR_NULL(clki->clk)) {
@@ -7413,16 +7406,9 @@ static int __ufshcd_setup_clocks(struct ufs_hba *hba, bool on, 
		}

	}



	/*

	 * vendor specific setup_clocks ops may depend on clocks managed by

	 * this standard driver hence call the vendor specific setup_clocks

	 * after enabling the clocks managed here.

	 */

	if (on) {

	ret = ufshcd_vops_setup_clocks(hba, on, POST_CHANGE);

	if (ret)

		return ret;

	}



out:

	if (ret) {