Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6453077a authored by Xiaobo Liu's avatar Xiaobo Liu Committed by Greg Kroah-Hartman
Browse files

net/atm: fix proc_mpc_write incorrect return value 



[ Upstream commit d8bde3bf7f82dac5fc68a62c2816793a12cafa2a ]

Then the input contains '\0' or '\n', proc_mpc_write has read them,
so the return value needs +1.

Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Signed-off-by: default avatarXiaobo Liu <cppcoffee@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 4258c473

net/atm/mpoa_proc.c

+2 −1
Original line number Diff line number Diff line
@@ -222,11 +222,12 @@ static ssize_t proc_mpc_write(struct file *file, const char __user *buff, 
	if (!page)

		return -ENOMEM;



	for (p = page, len = 0; len < nbytes; p++, len++) {

	for (p = page, len = 0; len < nbytes; p++) {

		if (get_user(*p, buff++)) {

			free_page((unsigned long)page);

			return -EFAULT;

		}

		len += 1;

		if (*p == '\0' || *p == '\n')

			break;

	}