Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6443bb1f authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

ipv6: Fix inet6_csk_bind_conflict() 



Commit fda48a0d (tcp: bind() fix when many ports are bound)
introduced a bug on IPV6 part.
We should not call ipv6_addr_any(inet6_rcv_saddr(sk2)) but
ipv6_addr_any(inet6_rcv_saddr(sk)) because sk2 can be IPV4, while sk is
IPV6.

Reported-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Signed-off-by: default avatarEric Dumazet <eric.dumazet@gmail.com>
Tested-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 401da6ae

net/ipv6/inet6_connection_sock.c

+1 −1
Original line number Diff line number Diff line
@@ -48,7 +48,7 @@ int inet6_csk_bind_conflict(const struct sock *sk, 
			     ipv6_rcv_saddr_equal(sk, sk2))

				break;

			else if (sk->sk_reuse && sk2->sk_reuse &&

				!ipv6_addr_any(inet6_rcv_saddr(sk2)) &&

				!ipv6_addr_any(inet6_rcv_saddr(sk)) &&

				ipv6_rcv_saddr_equal(sk, sk2))

				break;

		}