Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Unverified Commit 639e5eb3 authored by Charles Keepax's avatar Charles Keepax Committed by Mark Brown
Browse files

ASoC: wm_adsp: Correct handling of compressed streams that restart 



Previously support was added to allow streams to be stopped and
started again without the DSP being power cycled and this was done
by clearing the buffer state in trigger start. Another supported
use-case is using the DSP for a trigger event then opening the
compressed stream later to receive the audio, unfortunately clearing
the buffer state in trigger start destroys the data received
from such a trigger. Correct this issue by moving the call to
wm_adsp_buffer_clear to be in trigger stop instead.

Fixes: 61fc060c ("ASoC: wm_adsp: Support streams which can start/stop with DSP active")
Signed-off-by: default avatarCharles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 1c5b6a27

sound/soc/codecs/wm_adsp.c

+1 −2
Original line number Diff line number Diff line
@@ -3571,8 +3571,6 @@ int wm_adsp_compr_trigger(struct snd_compr_stream *stream, int cmd) 
		if (ret < 0)

			break;



		wm_adsp_buffer_clear(compr->buf);



		/* Trigger the IRQ at one fragment of data */

		ret = wm_adsp_buffer_write(compr->buf,

					   HOST_BUFFER_FIELD(high_water_mark),
@@ -3584,6 +3582,7 @@ int wm_adsp_compr_trigger(struct snd_compr_stream *stream, int cmd) 
		}

		break;

	case SNDRV_PCM_TRIGGER_STOP:

		wm_adsp_buffer_clear(compr->buf);

		break;

	default:

		ret = -EINVAL;