Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6390d33b authored by Luis R. Rodriguez's avatar Luis R. Rodriguez Committed by Theodore Ts'o
Browse files

ext4: add verifier check for symlink with append/immutable flags 



The Linux VFS does not allow a way to set append/immuttable
attributes to symlinks, this is just not possible. If this is
detected inform the user as the filesystem must be corrupted.

Signed-off-by: default avatarLuis R. Rodriguez <mcgrof@kernel.org>
Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
parent 71fe9899

fs/ext4/inode.c

+7 −0
Original line number Original line Diff line number Diff line
@@ -4965,6 +4965,13 @@ struct inode *ext4_iget(struct super_block *sb, unsigned long ino) 
		inode->i_op = &ext4_dir_inode_operations;

		inode->i_op = &ext4_dir_inode_operations;

		inode->i_fop = &ext4_dir_operations;

		inode->i_fop = &ext4_dir_operations;

	} else if (S_ISLNK(inode->i_mode)) {

	} else if (S_ISLNK(inode->i_mode)) {

		/* VFS does not allow setting these so must be corruption */

		if (IS_APPEND(inode) || IS_IMMUTABLE(inode)) {

			EXT4_ERROR_INODE(inode,

			  "immutable or append flags not allowed on symlinks");

			ret = -EFSCORRUPTED;

			goto bad_inode;

		}

		if (ext4_encrypted_inode(inode)) {

		if (ext4_encrypted_inode(inode)) {

			inode->i_op = &ext4_encrypted_symlink_inode_operations;

			inode->i_op = &ext4_encrypted_symlink_inode_operations;

			ext4_set_aops(inode);

			ext4_set_aops(inode);