Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 63871f71 authored by Tomi Valkeinen's avatar Tomi Valkeinen
Browse files

drm/omap: remove unnecessary pitch round-up



omapdrm checks if the pixel stride is divisible by 8. This is meant to
ensure that the byte stride is 32, which is required by SGX.

The check is not correct, as it checks for pixels, not bytes, and thus
needlessly increases the stride for, e.g., NV12.

Also, SGX driver is not supported in the mainline, and the TI's SGX
driver nowadays does the memory allocation itself and doesn't rely on
omapdrm to figure out the correct pitch.

So we can just remove the whole roundup.

Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
parent 6e4c6e60
Loading
Loading
Loading
Loading
+1 −4
Original line number Diff line number Diff line
@@ -244,10 +244,7 @@ static inline int align_pitch(int pitch, int width, int bpp)
	int bytespp = (bpp + 7) / 8;
	/* in case someone tries to feed us a completely bogus stride: */
	pitch = max(pitch, width * bytespp);
	/* PVR needs alignment to 8 pixels.. right now that is the most
	 * restrictive stride requirement..
	 */
	return roundup(pitch, 8 * bytespp);
	return pitch;
}

/* map crtc to vblank mask */