Commit 62ef5887 authored Dec 06, 2023 by Namjae Jeon Committed by Greg Kroah-Hartman Jan 08, 2024

ksmbd: fix wrong name of SMB2_CREATE_ALLOCATION_SIZE



[ Upstream commit 13736654481198e519059d4a2e2e3b20fa9fdb3e ]

MS confirm that "AISi" name of SMB2_CREATE_ALLOCATION_SIZE in MS-SMB2
specification is a typo. cifs/ksmbd have been using this wrong name from
MS-SMB2. It should be "AlSi". Also It will cause problem when running
smb2.create.open test in smbtorture against ksmbd.

Cc: stable@vger.kernel.org
Fixes: 12197a7f ("Clarify SMB2/SMB3 create context and add missing ones")
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Reviewed-by: Paulo Alcantara (SUSE) <pc@manguebit.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 35e12efd

fs/cifs/smb2pdu.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -651,7 +651,7 @@ struct smb2_tree_disconnect_rsp {
		#define SMB2_CREATE_SD_BUFFER "SecD" /* security descriptor */
		#define SMB2_CREATE_DURABLE_HANDLE_REQUEST "DHnQ"
		#define SMB2_CREATE_DURABLE_HANDLE_RECONNECT "DHnC"
		#define SMB2_CREATE_ALLOCATION_SIZE "AISi"
		#define SMB2_CREATE_ALLOCATION_SIZE "AlSi"
		#define SMB2_CREATE_QUERY_MAXIMAL_ACCESS_REQUEST "MxAc"
		#define SMB2_CREATE_TIMEWARP_REQUEST "TWrp"
		#define SMB2_CREATE_QUERY_ON_DISK_ID "QFid"