Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 62ebce1d authored by Oleksij Rempel's avatar Oleksij Rempel Committed by Marc Kleine-Budde
Browse files

can: j1939: make sure socket is held as long as session exists 



We link the socket to the session to be able provide socket specific
notifications. For example messages over error queue.

We need to keep the socket held, while we have a reference to it.

Fixes: 9d71dd0c ("can: add support of SAE J1939 protocol")
Signed-off-by: default avatarOleksij Rempel <o.rempel@pengutronix.de>
parent d966635b

net/can/j1939/transport.c

+2 −0
Original line number Diff line number Diff line
@@ -255,6 +255,7 @@ static void __j1939_session_drop(struct j1939_session *session) 
		return;



	j1939_sock_pending_del(session->sk);

	sock_put(session->sk);

}



static void j1939_session_destroy(struct j1939_session *session)
@@ -1875,6 +1876,7 @@ struct j1939_session *j1939_tp_send(struct j1939_priv *priv, 
		return ERR_PTR(-ENOMEM);



	/* skb is recounted in j1939_session_new() */

	sock_hold(skb->sk);

	session->sk = skb->sk;

	session->transmission = true;

	session->pkt.total = (size + 6) / 7;