Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 62bac4af authored by J. Bruce Fields's avatar J. Bruce Fields
Browse files

svcrpc: don't set then immediately clear XPT_DEFERRED 



There's no harm to doing this, since the only caller will immediately
call svc_enqueue() afterwards, ensuring we don't miss the remaining
deferred requests just because XPT_DEFERRED was briefly cleared.

But why not just do this the simple way?

Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
parent 43b0178e

net/sunrpc/svc_xprt.c

+2 −3
Original line number Diff line number Diff line
@@ -1059,14 +1059,13 @@ static struct svc_deferred_req *svc_deferred_dequeue(struct svc_xprt *xprt) 
	if (!test_bit(XPT_DEFERRED, &xprt->xpt_flags))

		return NULL;

	spin_lock(&xprt->xpt_lock);

	clear_bit(XPT_DEFERRED, &xprt->xpt_flags);

	if (!list_empty(&xprt->xpt_deferred)) {

		dr = list_entry(xprt->xpt_deferred.next,

				struct svc_deferred_req,

				handle.recent);

		list_del_init(&dr->handle.recent);

		set_bit(XPT_DEFERRED, &xprt->xpt_flags);

	}

	} else

		clear_bit(XPT_DEFERRED, &xprt->xpt_flags);

	spin_unlock(&xprt->xpt_lock);

	return dr;

}