Commit 62ade1be authored Feb 19, 2019 by YueHaibing Committed by Arnd Bergmann Feb 20, 2019

tee: optee: Fix unsigned comparison with less than zero



The return from the call to tee_client_invoke_func can be a
negative error code however this is being assigned to an
unsigned variable 'ret' hence the check is always false.
Fix this by making 'ret' an int.

Detected by Coccinelle ("Unsigned expression compared with zero:
ret < 0")

Fixes: c3fa24af ("tee: optee: add TEE bus device enumeration support")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Sumit Garg <sumit.garg@linaro.org>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

parent 8deed847

drivers/tee/optee/device.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -34,7 +34,7 @@ static int optee_ctx_match(struct tee_ioctl_version_data ver, const void data)
		static int get_devices(struct tee_context *ctx, u32 session,
		struct tee_shm device_shm, u32 shm_size)
		{
		u32 ret = 0;
		int ret = 0;
		struct tee_ioctl_invoke_arg inv_arg;
		struct tee_param param[4];