Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 62ab4505 authored by Thomas Gleixner's avatar Thomas Gleixner
Browse files

signals: implement sys_rt_tgsigqueueinfo 



sys_kill has the per thread counterpart sys_tgkill. sigqueueinfo is
missing a thread directed counterpart. Such an interface is important
for migrating applications from other OSes which have the per thread
delivery implemented.

Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Reviewed-by: default avatarOleg Nesterov <oleg@redhat.com>
Acked-by: default avatarRoland McGrath <roland@redhat.com>
Acked-by: default avatarUlrich Drepper <drepper@redhat.com>
parent 30b4ae8a

include/linux/compat.h

+2 −0
Original line number Diff line number Diff line
@@ -222,6 +222,8 @@ int copy_siginfo_from_user32(siginfo_t *to, struct compat_siginfo __user *from); 
int copy_siginfo_to_user32(struct compat_siginfo __user *to, siginfo_t *from);

int get_compat_sigevent(struct sigevent *event,

		const struct compat_sigevent __user *u_event);

long compat_sys_rt_tgsigqueueinfo(compat_pid_t tgid, compat_pid_t pid, int sig,

				  struct compat_siginfo __user *uinfo);



static inline int compat_timeval_compare(struct compat_timeval *lhs,

					struct compat_timeval *rhs)

include/linux/signal.h

+2 −0
Original line number Diff line number Diff line
@@ -235,6 +235,8 @@ static inline int valid_signal(unsigned long sig) 
extern int next_signal(struct sigpending *pending, sigset_t *mask);

extern int group_send_sig_info(int sig, struct siginfo *info, struct task_struct *p);

extern int __group_send_sig_info(int, struct siginfo *, struct task_struct *);

extern long do_rt_tgsigqueueinfo(pid_t tgid, pid_t pid, int sig,

				 siginfo_t *info);

extern long do_sigpending(void __user *, unsigned long);

extern int sigprocmask(int, sigset_t *, sigset_t *);

extern int show_unhandled_signals;

kernel/compat.c

+11 −0
Original line number Diff line number Diff line
@@ -882,6 +882,17 @@ compat_sys_rt_sigtimedwait (compat_sigset_t __user *uthese, 


}



asmlinkage long

compat_sys_rt_tgsigqueueinfo(compat_pid_t tgid, compat_pid_t pid, int sig,

			     struct compat_siginfo __user *uinfo)

{

	siginfo_t info;



	if (copy_siginfo_from_user32(&info, uinfo))

		return -EFAULT;

	return do_rt_tgsigqueueinfo(tgid, pid, sig, &info);

}



#ifdef __ARCH_WANT_COMPAT_SYS_TIME



/* compat_time_t is a 32 bit "long" and needs to get converted. */

kernel/signal.c

+26 −0
Original line number Diff line number Diff line
@@ -2369,6 +2369,32 @@ SYSCALL_DEFINE3(rt_sigqueueinfo, pid_t, pid, int, sig, 
	return kill_proc_info(sig, &info, pid);

}



long do_rt_tgsigqueueinfo(pid_t tgid, pid_t pid, int sig, siginfo_t *info)

{

	/* This is only valid for single tasks */

	if (pid <= 0 || tgid <= 0)

		return -EINVAL;



	/* Not even root can pretend to send signals from the kernel.

	   Nor can they impersonate a kill(), which adds source info.  */

	if (info->si_code >= 0)

		return -EPERM;

	info->si_signo = sig;



	return do_send_specific(tgid, pid, sig, info);

}



SYSCALL_DEFINE4(rt_tgsigqueueinfo, pid_t, tgid, pid_t, pid, int, sig,

		siginfo_t __user *, uinfo)

{

	siginfo_t info;



	if (copy_from_user(&info, uinfo, sizeof(siginfo_t)))

		return -EFAULT;



	return do_rt_tgsigqueueinfo(tgid, pid, sig, &info);

}



int do_sigaction(int sig, struct k_sigaction *act, struct k_sigaction *oact)

{

	struct task_struct *t = current;