Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 62a063b8 authored by J. Bruce Fields's avatar J. Bruce Fields
Browse files

nfsd4: fix crash on writing v4_end_grace before nfsd startup 



Anatoly Trosinenko reports that this:

1) Checkout fresh master Linux branch (tested with commit e195ca6c)
2) Copy x84_64-config-4.14 to .config, then enable NFS server v4 and build
3) From `kvm-xfstests shell`:

results in NULL dereference in locks_end_grace.

Check that nfsd has been started before trying to end the grace period.

Reported-by: default avatarAnatoly Trosinenko <anatoly.trosinenko@gmail.com>
Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
parent b8db1592

fs/nfsd/nfsctl.c

+2 −0
Original line number Diff line number Diff line
@@ -1126,6 +1126,8 @@ static ssize_t write_v4_end_grace(struct file *file, char *buf, size_t size) 
		case 'Y':

		case 'y':

		case '1':

			if (nn->nfsd_serv)

				return -EBUSY;

			nfsd4_end_grace(nn);

			break;

		default: