Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 62974fc3 authored by Dan Williams's avatar Dan Williams Committed by Jason Gunthorpe
Browse files

libnvdimm: Enable unit test infrastructure compile checks 

The infrastructure to mock core libnvdimm routines for unit testing
purposes is prone to bitrot relative to refactoring of that core.  Arrange
for the unit test core to be built when CONFIG_COMPILE_TEST=y.  This does
not result in a functional unit test environment, it is only a helper for
0day to catch unit test build regressions.

Note that there are a few x86isms in the implementation, so this does not
bother compile testing this architectures other than 64-bit x86.

Link: https://lore.kernel.org/r/156763690875.2556198.15786177395425033830.stgit@dwillia2-desk3.amr.corp.intel.com


Reported-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarDan Williams <dan.j.williams@intel.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
parent ba170f76

drivers/nvdimm/Kconfig

+12 −0
Original line number Diff line number Diff line
@@ -118,4 +118,16 @@ config NVDIMM_KEYS 
	depends on ENCRYPTED_KEYS

	depends on (LIBNVDIMM=ENCRYPTED_KEYS) || LIBNVDIMM=m



config NVDIMM_TEST_BUILD

	tristate "Build the unit test core"

	depends on m

	depends on COMPILE_TEST && X86_64

	default m if COMPILE_TEST

	help

	  Build the core of the unit test infrastructure. The result of

	  this build is non-functional for unit test execution, but it

	  otherwise helps catch build errors induced by changes to the

	  core devm_memremap_pages() implementation and other

	  infrastructure.



endif

drivers/nvdimm/Makefile

+4 −0
Original line number Diff line number Diff line
@@ -29,3 +29,7 @@ libnvdimm-$(CONFIG_BTT) += btt_devs.o 
libnvdimm-$(CONFIG_NVDIMM_PFN) += pfn_devs.o

libnvdimm-$(CONFIG_NVDIMM_DAX) += dax_devs.o

libnvdimm-$(CONFIG_NVDIMM_KEYS) += security.o



TOOLS := ../../tools

TEST_SRC := $(TOOLS)/testing/nvdimm/test

obj-$(CONFIG_NVDIMM_TEST_BUILD) += $(TEST_SRC)/iomap.o