Commit 626c5fe4 authored Jun 15, 2019 by Martin Blumenstingl Committed by David S. Miller Jun 16, 2019

net: stmmac: drop redundant check in stmmac_mdio_reset



A simplified version of the existing code looks like this:
  if (priv->device->of_node) {
      struct device_node *np = priv->device->of_node;
      if (!np)
          return 0;

The second "if" never evaluates to true because the first "if" checks
for exactly the opposite.
Drop the redundant check and early return to make the code easier to
understand.

No functional changes intended.

Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent a5148626

drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -256,9 +256,6 @@ int stmmac_mdio_reset(struct mii_bus *bus)
		if (data->reset_gpio < 0) {
		struct device_node *np = priv->device->of_node;

		if (!np)
		return 0;

		reset_gpio = devm_gpiod_get_optional(priv->device,
		"snps,reset",
		GPIOD_OUT_LOW);