Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 62354454 authored by David Kozub's avatar David Kozub Committed by Greg Kroah-Hartman
Browse files

USB: uas and storage: Add US_FL_BROKEN_FUA for another JMicron JMS567 ID 



There is another JMS567-based USB3 UAS enclosure (152d:0578) that fails
with the following error:

[sda] tag#0 FAILED Result: hostbyte=DID_OK driverbyte=DRIVER_SENSE
[sda] tag#0 Sense Key : Illegal Request [current]
[sda] tag#0 Add. Sense: Invalid field in cdb

The issue occurs both with UAS (occasionally) and mass storage
(immediately after mounting a FS on a disk in the enclosure).

Enabling US_FL_BROKEN_FUA quirk solves this issue.

This patch adds an UNUSUAL_DEV with US_FL_BROKEN_FUA for the enclosure
for both UAS and mass storage.

Signed-off-by: default avatarDavid Kozub <zub@linux.fjfi.cvut.cz>
Acked-by: default avatarAlan Stern <stern@rowland.harvard.edu>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent bd3486de

drivers/usb/storage/unusual_devs.h

+7 −0
Original line number Diff line number Diff line
@@ -2100,6 +2100,13 @@ UNUSUAL_DEV( 0x152d, 0x0567, 0x0114, 0x0116, 
		USB_SC_DEVICE, USB_PR_DEVICE, NULL,

		US_FL_BROKEN_FUA ),



/* Reported by David Kozub <zub@linux.fjfi.cvut.cz> */

UNUSUAL_DEV(0x152d, 0x0578, 0x0000, 0x9999,

		"JMicron",

		"JMS567",

		USB_SC_DEVICE, USB_PR_DEVICE, NULL,

		US_FL_BROKEN_FUA),



/*

 * Reported by Alexandre Oliva <oliva@lsd.ic.unicamp.br>

 * JMicron responds to USN and several other SCSI ioctls with a

drivers/usb/storage/unusual_uas.h

+7 −0
Original line number Diff line number Diff line
@@ -129,6 +129,13 @@ UNUSUAL_DEV(0x152d, 0x0567, 0x0000, 0x9999, 
		USB_SC_DEVICE, USB_PR_DEVICE, NULL,

		US_FL_BROKEN_FUA | US_FL_NO_REPORT_OPCODES),



/* Reported-by: David Kozub <zub@linux.fjfi.cvut.cz> */

UNUSUAL_DEV(0x152d, 0x0578, 0x0000, 0x9999,

		"JMicron",

		"JMS567",

		USB_SC_DEVICE, USB_PR_DEVICE, NULL,

		US_FL_BROKEN_FUA),



/* Reported-by: Hans de Goede <hdegoede@redhat.com> */

UNUSUAL_DEV(0x2109, 0x0711, 0x0000, 0x9999,

		"VIA",