Commit 61e8b858 authored Apr 09, 2007 by Alan Stern Committed by Greg Kroah-Hartman Apr 11, 2007

EHCI: fix remote wakeup regression in 2.6.21-rc



There is one significant difference between the behavior of root hubs
(as embodied in host controller hardware) and external hubs: When a
remote-wakeup signal is received, an external hub sends an interrupt
message at the _end_ of the resume sequence but a root hub generates
and interrupt at the _beginning_ of the resume sequence.  The host
system must poll for the end of the sequence.

When ehci-hcd was converted to interrupt-driven operation instead of
using polling, the remaining need for this particular poll was
overlooked.  This patch (as894) fixes the problem.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent 5ab7ffea

drivers/usb/host/ehci-hcd.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -669,6 +669,7 @@ static irqreturn_t ehci_irq (struct usb_hcd *hcd)
		*/
		ehci->reset_done [i] = jiffies + msecs_to_jiffies (20);
		ehci_dbg (ehci, "port %d remote wakeup\n", i + 1);
		mod_timer(&hcd->rh_timer, ehci->reset_done[i]);
		}
		}