Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 61c0ee87 authored by Paul Davies C's avatar Paul Davies C Committed by Eric Paris
Browse files

audit: drop audit_log_abend() 



The audit_log_abend() is used only by the audit_core_dumps(). Thus there is no
need of maintaining the audit_log_abend() as a separate function.

This patch drops the audit_log_abend() and pushes its functionalities back to
the audit_core_dumps(). Apart from that the "reason" field is also dropped
from being logged since the reason can be deduced from the signal number.

Signed-off-by: default avatarPaul Davies C <pauldaviesc@gmail.com>
Acked-by: default avatarEric Paris <eparis@redhat.com>
Signed-off-by: default avatarRichard Guy Briggs <rgb@redhat.com>
Signed-off-by: default avatarEric Paris <eparis@redhat.com>
parent 40c0775e

kernel/auditsc.c

+2 −8
Original line number Diff line number Diff line
@@ -2368,13 +2368,6 @@ static void audit_log_task(struct audit_buffer *ab) 
	audit_log_untrustedstring(ab, current->comm);

}



static void audit_log_abend(struct audit_buffer *ab, char *reason, long signr)

{

	audit_log_task(ab);

	audit_log_format(ab, " reason=");

	audit_log_string(ab, reason);

	audit_log_format(ab, " sig=%ld", signr);

}

/**

 * audit_core_dumps - record information about processes that end abnormally

 * @signr: signal value
@@ -2395,7 +2388,8 @@ void audit_core_dumps(long signr) 
	ab = audit_log_start(NULL, GFP_KERNEL, AUDIT_ANOM_ABEND);

	if (unlikely(!ab))

		return;

	audit_log_abend(ab, "memory violation", signr);

	audit_log_task(ab);

	audit_log_format(ab, " sig=%ld", signr);

	audit_log_end(ab);

}