Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 619ed392 authored by Byongho Lee's avatar Byongho Lee Committed by David Sterba
Browse files

btrfs: cleanup iterating over prop_handlers array 



This patch eliminates the last item of prop_handlers array which is used
to check end of array and instead uses ARRAY_SIZE macro.
Though this is a very tiny optimization, using ARRAY_SIZE macro is a
good practice to iterate array.

Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarByongho Lee <bhlee.kernel@gmail.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 8cd1e731

fs/btrfs/props.c

+6 −7
Original line number Diff line number Diff line
@@ -49,18 +49,16 @@ static struct prop_handler prop_handlers[] = { 
		.extract = prop_compression_extract,

		.inheritable = 1

	},

	{

		.xattr_name = NULL

	}

};



void __init btrfs_props_init(void)

{

	struct prop_handler *p;

	int i;



	hash_init(prop_handlers_ht);



	for (p = &prop_handlers[0]; p->xattr_name; p++) {

	for (i = 0; i < ARRAY_SIZE(prop_handlers); i++) {

		struct prop_handler *p = &prop_handlers[i];

		u64 h = btrfs_name_hash(p->xattr_name, strlen(p->xattr_name));



		hash_add(prop_handlers_ht, &p->node, h);
@@ -301,15 +299,16 @@ static int inherit_props(struct btrfs_trans_handle *trans, 
			 struct inode *inode,

			 struct inode *parent)

{

	const struct prop_handler *h;

	struct btrfs_root *root = BTRFS_I(inode)->root;

	int ret;

	int i;



	if (!test_bit(BTRFS_INODE_HAS_PROPS,

		      &BTRFS_I(parent)->runtime_flags))

		return 0;



	for (h = &prop_handlers[0]; h->xattr_name; h++) {

	for (i = 0; i < ARRAY_SIZE(prop_handlers); i++) {

		const struct prop_handler *h = &prop_handlers[i];

		const char *value;

		u64 num_bytes;