Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6183d5a5 authored by Kangjie Lu's avatar Kangjie Lu Committed by Mika Westerberg
Browse files

thunderbolt: property: Fix a missing check of kzalloc 



No check is enforced for the return value of kzalloc,
which may lead to NULL-pointer dereference.

The patch fixes this issue.

Signed-off-by: default avatarKangjie Lu <kjlu@umn.edu>
Reviewed-by: default avatarMukesh Ojha <mojha@codeaurora.org>
Signed-off-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
parent 48f40b96

drivers/thunderbolt/property.c

+6 −1
Original line number Diff line number Diff line
@@ -587,7 +587,12 @@ int tb_property_add_text(struct tb_property_dir *parent, const char *key, 
		return -ENOMEM;



	property->length = size / 4;

	property->value.data = kzalloc(size, GFP_KERNEL);

	property->value.text = kzalloc(size, GFP_KERNEL);

	if (!property->value.text) {

		kfree(property);

		return -ENOMEM;

	}



	strcpy(property->value.text, text);



	list_add_tail(&property->list, &parent->properties);