Commit 6124d0b1 authored Oct 20, 2023 by Douglas Anderson Committed by Greg Kroah-Hartman Nov 08, 2023

r8152: Run the unload routine if we have errors during probe



[ Upstream commit 5dd17689526971c5ae12bc8398f34bd68cd0499e ]

The rtl8152_probe() function lacks a call to the chip-specific
unload() routine when it sees an error in probe. Add it in to match
the cleanup code in rtl8152_disconnect().

Fixes: ac718b69 ("net/usb: new driver for RTL8152")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Grant Grundler <grundler@chromium.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 1d3cb4aa

drivers/net/usb/r8152.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -5779,6 +5779,8 @@ static int rtl8152_probe(struct usb_interface *intf,

		out1:
		tasklet_kill(&tp->tx_tl);
		if (tp->rtl_ops.unload)
		tp->rtl_ops.unload(tp);
		usb_set_intfdata(intf, NULL);
		out:
		free_netdev(netdev);