Commit 60fc75bd authored Feb 28, 2018 by Geert Uytterhoeven Committed by Simon Horman Feb 28, 2018

ARM: shmobile: rcar-gen2: Fix error check in regulator quirk



On systems with two regulators, a bogus error message is printed on
success:

    i2c 6-0058: i2c error 2

While adding support for Stout, the number of messages to send was
made variable, but the corresponding return value check of
i2c_transfer() wasn't updated.

Fixes: ff938cd1 ("ARM: shmobile: stout: enable R-Car Gen2 regulator quirk")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>

parent bf79cd63

arch/arm/mach-shmobile/regulator-quirk-rcar-gen2.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -98,7 +98,7 @@ static int regulator_quirk_notify(struct notifier_block *nb,

		dev_info(&client->dev, "clearing da9063/da9210 interrupts\n");
		ret = i2c_transfer(client->adapter, da9xxx_msgs, len);
		if (ret != ARRAY_SIZE(da9xxx_msgs))
		if (ret != len)
		dev_err(&client->dev, "i2c error %d\n", ret);
		}