Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 60f8e67d authored by Antoine Tenart's avatar Antoine Tenart Committed by David S. Miller
Browse files

net: mscc: allow extracting the FCS into the skb 



This patch adds support for the NETIF_F_RXFCS feature in the Mscc
Ethernet driver. This feature is disabled by default and allow a user
to request the driver not to drop the FCS and to extract it into the skb
for debugging purposes.

Signed-off-by: default avatarAntoine Tenart <antoine.tenart@bootlin.com>
Reviewed-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b7ec45a8

drivers/net/ethernet/mscc/ocelot.c

+1 −1
Original line number Diff line number Diff line
@@ -1620,7 +1620,7 @@ int ocelot_probe_port(struct ocelot *ocelot, u8 port, 
	dev->ethtool_ops = &ocelot_ethtool_ops;

	dev->switchdev_ops = &ocelot_port_switchdev_ops;



	dev->hw_features |= NETIF_F_HW_VLAN_CTAG_FILTER;

	dev->hw_features |= NETIF_F_HW_VLAN_CTAG_FILTER | NETIF_F_RXFCS;

	dev->features |= NETIF_F_HW_VLAN_CTAG_FILTER;



	memcpy(dev->dev_addr, ocelot->base_mac, ETH_ALEN);

drivers/net/ethernet/mscc/ocelot_board.c

+6 −1
Original line number Diff line number Diff line
@@ -128,11 +128,16 @@ static irqreturn_t ocelot_xtr_irq_handler(int irq, void *arg) 
			len += sz;

		} while (len < buf_len);



		/* Read the FCS and discard it */

		/* Read the FCS */

		sz = ocelot_rx_frame_word(ocelot, grp, false, &val);

		/* Update the statistics if part of the FCS was read before */

		len -= ETH_FCS_LEN - sz;



		if (unlikely(dev->features & NETIF_F_RXFCS)) {

			buf = (u32 *)skb_put(skb, ETH_FCS_LEN);

			*buf = val;

		}



		if (sz < 0) {

			err = sz;

			break;