Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 60dcc39e authored by Kiran Patil's avatar Kiran Patil Committed by Jeff Kirsher
Browse files

ice: fix the divide by zero issue 



Static analysis flagged a potential divide by zero error because
vsi->num_rxq can become zero in certain condition and it is used as
divisor.

Signed-off-by: default avatarKiran Patil <kiran.patil@intel.com>
Signed-off-by: default avatarAnirudh Venkataramanan <anirudh.venkataramanan@intel.com>
Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent 5743020d

drivers/net/ethernet/intel/ice/ice_lib.c

+12 −1
Original line number Diff line number Diff line
@@ -881,7 +881,18 @@ static void ice_vsi_setup_q_map(struct ice_vsi *vsi, struct ice_vsi_ctx *ctxt) 
		tx_count += tx_numq_tc;

		ctxt->info.tc_mapping[i] = cpu_to_le16(qmap);

	}



	/* if offset is non-zero, means it is calculated correctly based on

	 * enabled TCs for a given VSI otherwise qcount_rx will always

	 * be correct and non-zero because it is based off - VSI's

	 * allocated Rx queues which is at least 1 (hence qcount_tx will be

	 * at least 1)

	 */

	if (offset)

		vsi->num_rxq = offset;

	else

		vsi->num_rxq = qcount_rx;



	vsi->num_txq = tx_count;



	if (vsi->type == ICE_VSI_VF && vsi->num_txq != vsi->num_rxq) {