Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 60b903c3 authored by Laurent Pinchart's avatar Laurent Pinchart Committed by Tomi Valkeinen
Browse files

drm/bridge: ti-tfp410: Set connector type based on DT connector node 



The TI TFP410 is a DVI encoder, not a full HDMI encoder. Its output can
be routed to a DVI-D connector, even if in many cases embedded systems
will use an HDMI connector to carry the DVI signals.

Instead of hardcoding the connector type to HDMI, retrieve the connector
type from its DT node.

Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
Reviewed-by: default avatarJyri Sarha <jsarha@ti.com>
Tested-by: default avatarSebastian Reichel <sebastian.reichel@collabora.com>
Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
parent 2645d8d0

drivers/gpu/drm/bridge/ti-tfp410.c

+7 −1
Original line number Diff line number Diff line
@@ -27,6 +27,7 @@ 
struct tfp410 {

	struct drm_bridge	bridge;

	struct drm_connector	connector;

	unsigned int		connector_type;



	struct i2c_adapter	*ddc;

	struct gpio_desc	*hpd;
@@ -126,7 +127,7 @@ static int tfp410_attach(struct drm_bridge *bridge) 
	drm_connector_helper_add(&dvi->connector,

				 &tfp410_con_helper_funcs);

	ret = drm_connector_init(bridge->dev, &dvi->connector,

				 &tfp410_con_funcs, DRM_MODE_CONNECTOR_HDMIA);

				 &tfp410_con_funcs, dvi->connector_type);

	if (ret) {

		dev_err(dvi->dev, "drm_connector_init() failed: %d\n", ret);

		return ret;
@@ -172,6 +173,11 @@ static int tfp410_get_connector_properties(struct tfp410 *dvi) 
	if (!connector_node)

		return -ENODEV;



	if (of_device_is_compatible(connector_node, "hdmi-connector"))

		dvi->connector_type = DRM_MODE_CONNECTOR_HDMIA;

	else

		dvi->connector_type = DRM_MODE_CONNECTOR_DVID;



	dvi->hpd = fwnode_get_named_gpiod(&connector_node->fwnode,

					"hpd-gpios", 0, GPIOD_IN, "hpd");

	if (IS_ERR(dvi->hpd)) {