Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 60af6e68 authored by Mike Marciniszyn's avatar Mike Marciniszyn Committed by Greg Kroah-Hartman
Browse files

IB/rdmavt: Validate remote_addr during loopback atomic tests 

commit 4028bccb003cf67e46632dee7f97ddc5d7b6e685 upstream.

The rdma-core test suite sends an unaligned remote address and expects a
failure.

ERROR: test_atomic_non_aligned_addr (tests.test_atomic.AtomicTest)

The qib/hfi1 rc handling validates properly, but the test has the client
and server on the same system.

The loopback of these operations is a distinct code path.

Fix by syntaxing the proposed remote address in the loopback code path.

Fixes: 15703461 ("IB/{hfi1, qib, rdmavt}: Move ruc_loopback to rdmavt")
Link: https://lore.kernel.org/r/1642584489-141005-1-git-send-email-mike.marciniszyn@cornelisnetworks.com


Reviewed-by: default avatarDennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
Signed-off-by: default avatarMike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 4bbb6e6a

drivers/infiniband/sw/rdmavt/qp.c

+2 −0
Original line number Diff line number Diff line
@@ -3110,6 +3110,8 @@ void rvt_ruc_loopback(struct rvt_qp *sqp) 
	case IB_WR_ATOMIC_FETCH_AND_ADD:

		if (unlikely(!(qp->qp_access_flags & IB_ACCESS_REMOTE_ATOMIC)))

			goto inv_err;

		if (unlikely(wqe->atomic_wr.remote_addr & (sizeof(u64) - 1)))

			goto inv_err;

		if (unlikely(!rvt_rkey_ok(qp, &qp->r_sge.sge, sizeof(u64),

					  wqe->atomic_wr.remote_addr,

					  wqe->atomic_wr.rkey,