Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6044bd4a authored by Haishuang Yan's avatar Haishuang Yan Committed by David S. Miller
Browse files

devlink: fix potential memort leak 



We must free allocated skb when genlmsg_put() return fails.

Fixes: 1555d204 ("devlink: Support for pipeline debug (dpipe)")
Signed-off-by: default avatarHaishuang Yan <yanhaishuang@cmss.chinamobile.com>
Acked-by: default avatarJiri Pirko <jiri@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 1e0ce2a1

net/core/devlink.c

+6 −2
Original line number Diff line number Diff line
@@ -1680,8 +1680,10 @@ static int devlink_dpipe_tables_fill(struct genl_info *info, 


	hdr = genlmsg_put(skb, info->snd_portid, info->snd_seq,

			  &devlink_nl_family, NLM_F_MULTI, cmd);

	if (!hdr)

	if (!hdr) {

		nlmsg_free(skb);

		return -EMSGSIZE;

	}



	if (devlink_nl_put_handle(skb, devlink))

		goto nla_put_failure;
@@ -2098,8 +2100,10 @@ static int devlink_dpipe_headers_fill(struct genl_info *info, 


	hdr = genlmsg_put(skb, info->snd_portid, info->snd_seq,

			  &devlink_nl_family, NLM_F_MULTI, cmd);

	if (!hdr)

	if (!hdr) {

		nlmsg_free(skb);

		return -EMSGSIZE;

	}



	if (devlink_nl_put_handle(skb, devlink))

		goto nla_put_failure;