Commit 6026685d authored May 03, 2017 by David Disseldorp Committed by Steve French May 03, 2017

cifs: fix CIFS_ENUMERATE_SNAPSHOTS oops



As with 61876395, an open directory may have a NULL private_data
pointer prior to readdir. CIFS_ENUMERATE_SNAPSHOTS must check for this
before dereference.

Fixes: 834170c8 ("Enable previous version support")
Signed-off-by: David Disseldorp <ddiss@suse.de>
CC: Stable <stable@vger.kernel.org>
Signed-off-by: Steve French <smfrench@gmail.com>

parent 0e5c7955

fs/cifs/ioctl.c

+2 −0

Original line number	Original line	Diff line number	Diff line
	@@ -213,6 +213,8 @@ long cifs_ioctl(struct file *filep, unsigned int command, unsigned long arg)
	rc = smb_mnt_get_fsinfo(xid, tcon, (void __user *)arg);		rc = smb_mnt_get_fsinfo(xid, tcon, (void __user *)arg);
	break;		break;
	case CIFS_ENUMERATE_SNAPSHOTS:		case CIFS_ENUMERATE_SNAPSHOTS:
			if (pSMBFile == NULL)
			break;
	if (arg == 0) {		if (arg == 0) {
	rc = -EINVAL;		rc = -EINVAL;
	goto cifs_ioc_exit;		goto cifs_ioc_exit;