Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 60209d48 authored by Ping-Ke Shih's avatar Ping-Ke Shih Committed by Kalle Valo
Browse files

rtlwifi: fix potential NULL pointer dereference 



In case dev_alloc_skb fails, the fix safely returns to avoid
potential NULL pointer dereference.

Signed-off-by: default avatarPing-Ke Shih <pkshih@realtek.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent 76597628

drivers/net/wireless/realtek/rtlwifi/rtl8188ee/fw.c

+2 −0
Original line number Diff line number Diff line
@@ -600,6 +600,8 @@ void rtl88e_set_fw_rsvdpagepkt(struct ieee80211_hw *hw, bool b_dl_finished) 
		      u1rsvdpageloc, 3);



	skb = dev_alloc_skb(totalpacketlen);

	if (!skb)

		return;

	skb_put_data(skb, &reserved_page_packet, totalpacketlen);



	rtstatus = rtl_cmd_send_packet(hw, skb);

drivers/net/wireless/realtek/rtlwifi/rtl8192c/fw_common.c

+2 −0
Original line number Diff line number Diff line
@@ -623,6 +623,8 @@ void rtl92c_set_fw_rsvdpagepkt(struct ieee80211_hw *hw, 
		      u1rsvdpageloc, 3);



	skb = dev_alloc_skb(totalpacketlen);

	if (!skb)

		return;

	skb_put_data(skb, &reserved_page_packet, totalpacketlen);



	if (cmd_send_packet)

drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c

+2 −0
Original line number Diff line number Diff line
@@ -744,6 +744,8 @@ void rtl92ee_set_fw_rsvdpagepkt(struct ieee80211_hw *hw, bool b_dl_finished) 
		      u1rsvdpageloc, 3);



	skb = dev_alloc_skb(totalpacketlen);

	if (!skb)

		return;

	skb_put_data(skb, &reserved_page_packet, totalpacketlen);



	rtstatus = rtl_cmd_send_packet(hw, skb);

drivers/net/wireless/realtek/rtlwifi/rtl8723ae/fw.c

+2 −0
Original line number Diff line number Diff line
@@ -448,6 +448,8 @@ void rtl8723e_set_fw_rsvdpagepkt(struct ieee80211_hw *hw, bool b_dl_finished) 
		      u1rsvdpageloc, 3);



	skb = dev_alloc_skb(totalpacketlen);

	if (!skb)

		return;

	skb_put_data(skb, &reserved_page_packet, totalpacketlen);



	rtstatus = rtl_cmd_send_packet(hw, skb);

drivers/net/wireless/realtek/rtlwifi/rtl8723be/fw.c

+2 −0
Original line number Diff line number Diff line
@@ -562,6 +562,8 @@ void rtl8723be_set_fw_rsvdpagepkt(struct ieee80211_hw *hw, 
		      u1rsvdpageloc, sizeof(u1rsvdpageloc));



	skb = dev_alloc_skb(totalpacketlen);

	if (!skb)

		return;

	skb_put_data(skb, &reserved_page_packet, totalpacketlen);



	rtstatus = rtl_cmd_send_packet(hw, skb);