Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5f9994bd authored by Michael Braun's avatar Michael Braun Committed by Johannes Berg
Browse files

mac80211: remove unnecessary num_mcast_sta check 



Checking for num_mcast_sta in __ieee80211_request_smps_ap() is
unnecessary as sta list will be empty in this case anyway, so
the list iteration will just exit immediately. Since this isn't
a "hot" code path, it doesn't really matter, and the next patch
will redefine num_mcast_sta to make this check invalid.

Signed-off-by: default avatarMichael Braun <michael-dev@fami-braun.de>
[change commit message]
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 246ad56e

net/mac80211/cfg.c

+0 −7
Original line number Diff line number Diff line
@@ -2477,13 +2477,6 @@ int __ieee80211_request_smps_ap(struct ieee80211_sub_if_data *sdata, 
	    smps_mode == IEEE80211_SMPS_AUTOMATIC)

		return 0;



	 /* If no associated stations, there's no need to do anything */

	if (!atomic_read(&sdata->u.ap.num_mcast_sta)) {

		sdata->smps_mode = smps_mode;

		ieee80211_queue_work(&sdata->local->hw, &sdata->recalc_smps);

		return 0;

	}



	ht_dbg(sdata,

	       "SMPS %d requested in AP mode, sending Action frame to %d stations\n",

	       smps_mode, atomic_read(&sdata->u.ap.num_mcast_sta));