Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5f3d932f authored by Lars-Peter Clausen's avatar Lars-Peter Clausen Committed by Greg Kroah-Hartman
Browse files

iio: dln2: Check return value of devm_iio_trigger_register() 



commit 90751fb9f224e0e1555b49a8aa9e68f6537e4cec upstream.

Registering a trigger can fail and the return value of
devm_iio_trigger_register() must be checked. Otherwise undefined behavior
can occur when the trigger is used.

Fixes: 7c0299e8 ("iio: adc: Add support for DLN2 ADC")
Signed-off-by: default avatarLars-Peter Clausen <lars@metafoo.de>
Link: https://lore.kernel.org/r/20211101133043.6974-1-lars@metafoo.de


Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7447f045

drivers/iio/adc/dln2-adc.c

+5 −1
Original line number Diff line number Diff line
@@ -665,7 +665,11 @@ static int dln2_adc_probe(struct platform_device *pdev) 
		return -ENOMEM;

	}

	iio_trigger_set_drvdata(dln2->trig, dln2);

	devm_iio_trigger_register(dev, dln2->trig);

	ret = devm_iio_trigger_register(dev, dln2->trig);

	if (ret) {

		dev_err(dev, "failed to register trigger: %d\n", ret);

		return ret;

	}

	iio_trigger_set_immutable(indio_dev, dln2->trig);



	ret = devm_iio_triggered_buffer_setup(dev, indio_dev, NULL,