Commit 5f30b2e8 authored Dec 14, 2018 by Nicholas Mc Guire Committed by Jiri Kosina Dec 18, 2018

livepatch: check kzalloc return values



kzalloc() return should always be checked - notably in example code
where this may be seen as reference. On failure of allocation in
livepatch_fix1_dummy_alloc() respectively dummy_alloc() previous
allocation is freed (thanks to Petr Mladek <pmladek@suse.com> for
catching this) and NULL returned.

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Fixes: 439e7271 ("livepatch: introduce shadow variable API")
Acked-by: Joe Lawrence <joe.lawrence@redhat.com>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Acked-by: Miroslav Benes <mbenes@suse.cz>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

parent 3933ec73

samples/livepatch/livepatch-shadow-fix1.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -89,6 +89,11 @@ struct dummy *livepatch_fix1_dummy_alloc(void)
		* pointer to handle resource release.
		*/
		leak = kzalloc(sizeof(int), GFP_KERNEL);
		if (!leak) {
		kfree(d);
		return NULL;
		}

		klp_shadow_alloc(d, SV_LEAK, sizeof(leak), GFP_KERNEL,
		shadow_leak_ctor, leak);

samples/livepatch/livepatch-shadow-mod.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -118,6 +118,10 @@ noinline struct dummy *dummy_alloc(void)

		/* Oops, forgot to save leak! */
		leak = kzalloc(sizeof(int), GFP_KERNEL);
		if (!leak) {
		kfree(d);
		return NULL;
		}

		pr_info("%s: dummy @ %p, expires @ %lx\n",
		__func__, d, d->jiffies_expire);