Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5efb3f91 authored by Alexandru Ardelean's avatar Alexandru Ardelean Committed by Greg Kroah-Hartman
Browse files

iio: dac: ad5592r: fix unbalanced mutex unlocks in ad5592r_read_raw() 



commit 65afb0932a81c1de719ceee0db0b276094b10ac8 upstream.

There are 2 exit paths where the lock isn't held, but try to unlock the
mutex when exiting. In these places we should just return from the
function.

A neater approach would be to cleanup the ad5592r_read_raw(), but that
would make this patch more difficult to backport to stable versions.

Fixes 56ca9db8: ("iio: dac: Add support for the AD5592R/AD5593R ADCs/DACs")
Reported-by: default avatarCharles Stanhope <charles.stanhope@gmail.com>
Signed-off-by: default avatarAlexandru Ardelean <alexandru.ardelean@analog.com>
Cc: <Stable@vger.kernel.org>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 1a5e5b3b

drivers/iio/dac/ad5592r-base.c

+2 −2
Original line number Diff line number Diff line
@@ -416,7 +416,7 @@ static int ad5592r_read_raw(struct iio_dev *iio_dev, 
			s64 tmp = *val * (3767897513LL / 25LL);

			*val = div_s64_rem(tmp, 1000000000LL, val2);



			ret = IIO_VAL_INT_PLUS_MICRO;

			return IIO_VAL_INT_PLUS_MICRO;

		} else {

			int mult;
@@ -447,7 +447,7 @@ static int ad5592r_read_raw(struct iio_dev *iio_dev, 
		ret =  IIO_VAL_INT;

		break;

	default:

		ret = -EINVAL;

		return -EINVAL;

	}



unlock: