Commit 5ef8d792 authored Jul 30, 2015 by Kinglong Mee Committed by Trond Myklebust Aug 12, 2015

NFS: Error out when register_shrinker fail in register_nfs_fs



Commit 1d3d4437 "vmscan: per-node deferred work" have made
register_shrinker can return an intergater error.

If register_shrinker() fail, the later unregister_shrinker() will
 cause a NULL pointer access.

v2, same as v1.

Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>

parent efcbc04e

fs/nfs/super.c

+5 −2

Original line number	Diff line number	Diff line
		@@ -381,9 +381,12 @@ int __init register_nfs_fs(void)
		ret = nfs_register_sysctl();
		if (ret < 0)
		goto error_2;
		register_shrinker(&acl_shrinker);
		ret = register_shrinker(&acl_shrinker);
		if (ret < 0)
		goto error_3;
		return 0;

		error_3:
		nfs_unregister_sysctl();
		error_2:
		unregister_nfs4_fs();
		error_1: