Commit 5e98318c authored Jul 13, 2023 by Wang Ming Committed by Greg Kroah-Hartman Aug 11, 2023

i40e: Fix an NULL vs IS_ERR() bug for debugfs_create_dir()



[ Upstream commit 043b1f185fb0f3939b7427f634787706f45411c4 ]

The debugfs_create_dir() function returns error pointers.
It never returns NULL. Most incorrect error checks were fixed,
but the one in i40e_dbg_init() was forgotten.

Fix the remaining error check.

Fixes: 02e9c290 ("i40e: debugfs interface")
Signed-off-by: Wang Ming <machel@vivo.com>
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 6b1ee62e

drivers/net/ethernet/intel/i40e/i40e_debugfs.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1755,7 +1755,7 @@ void i40e_dbg_pf_exit(struct i40e_pf *pf)
		void i40e_dbg_init(void)
		{
		i40e_dbg_root = debugfs_create_dir(i40e_driver_name, NULL);
		if (!i40e_dbg_root)
		if (IS_ERR(i40e_dbg_root))
		pr_info("init of debugfs failed\n");
		}