Commit 5e40508e authored Dec 22, 2006 by Akinobu Mita Committed by Linus Torvalds Dec 22, 2006

[PATCH] tlclk: delete unnecessary sysfs_remove_group



It is unnecessary and invalid to call sysfs_remove_group() after
sysfs_create_group() failure.

Cc: Sebastien Bouchard <sebastien.bouchard@ca.kontron.com>
Cc: Mark Gross <mark.gross@intel.com>
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent 449d4dd5

drivers/char/tlclk.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -807,8 +807,6 @@ static int __init tlclk_init(void)
		&tlclk_attribute_group);
		if (ret) {
		printk(KERN_ERR "tlclk: failed to create sysfs device attributes.\n");
		sysfs_remove_group(&tlclk_device->dev.kobj,
		&tlclk_attribute_group);
		goto out5;
		}