Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5e3f7847 authored by Andrei Lalaev's avatar Andrei Lalaev Committed by Greg Kroah-Hartman
Browse files

Input: qt1050 - handle CHIP_ID reading error 



[ Upstream commit 866a5c7e2781cf1b019072288f1f5c64186dcb63 ]

If the device is missing, we get the following error:

  qt1050 3-0041: ID -1340767592 not supported

Let's handle this situation and print more informative error
when reading of CHIP_ID fails:

  qt1050 3-0041: Failed to read chip ID: -6

Fixes: cbebf5ad ("Input: qt1050 - add Microchip AT42QT1050 support")
Signed-off-by: default avatarAndrei Lalaev <andrei.lalaev@anton-paar.com>
Reviewed-by: default avatarMarco Felsch <m.felsch@pengutronix.de>
Link: https://lore.kernel.org/r/20240617183018.916234-1-andrey.lalaev@gmail.com


Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 3881d062

drivers/input/keyboard/qt1050.c

+6 −1
Original line number Diff line number Diff line
@@ -226,7 +226,12 @@ static bool qt1050_identify(struct qt1050_priv *ts) 
	int err;



	/* Read Chip ID */

	regmap_read(ts->regmap, QT1050_CHIP_ID, &val);

	err = regmap_read(ts->regmap, QT1050_CHIP_ID, &val);

	if (err) {

		dev_err(&ts->client->dev, "Failed to read chip ID: %d\n", err);

		return false;

	}



	if (val != QT1050_CHIP_ID_VER) {

		dev_err(&ts->client->dev, "ID %d not supported\n", val);

		return false;